Bloplang Pull Request #48592: Add zip
method to iterators
This is a proposal to add the zip
method to iterators. This would allow you to join two iterators together, alternating between results from both. E.g. tens.zip(hundreds)
would give [10, 100, 20, 200, 30]...
. This has been the most requested feature on our wishlist for seven months, and my initial implementation here provides a 12% speed up on the test_cases/thousands_of_types.blop
. 👍 532 👎 12 🚀 226 👀 114 😕 3
BlobBot says: Hi red_bean
! Thanks for opening a pull request to Bloplang! I've run your code, and found this: Maximum regression: 0.05%. Maximum improvement: 12.03%. I've assigned curly_brace
to approve your code. Don't forget to leave a star! 👍 221 🚀 179 👀 12
BlopBot added the "BlopBot Seal of Approval" "No regressions" labels.
I've never heard of "zip" before. Googling it, it seems to be a compression algorithm? Not sure what this has to do with iterators. I suggest naming it interleave
instead. 👍 23 👎 34
zip
seems to be pretty widely accepted. For example, Rust and Python call it zip
. 👍 27 😕 1
yeah i've never head of zip before. interleave is too long tho, how about weave 👍 54 👎 27
↕️ This comment was marked as off-topic.
ℹ️
requested 1 change.
This for
loop could be better expressed as a map
. 😕 1
How about spritz
? In the idiolect of English spoken by my Discord server, spritz
is very commonly used to refer to mixing things together. EDIT If you're going to laugh react, please leave a comment explaining why. 👍 5 😆 143
wtf is a spritz 👎 5 😕 26
↕️ This comment was marked as off-topic.
↕️ This comment was marked as off-topic.
Please don't leave "+1" comments. They pollute the thread and send useless emails. Use the react feature to add thumbs ups to the pull request if you want to express your approval. 👍 118 👎 4
who else is here from reddit? 👎 122 😆 16 😕 33
- [ Click to load 281 additional comments ] *
That's a bug with your Linux distribution’s zip
command, which has nothing to do with Bloplang. Open a thread on the Fedora forums to discuss that, although they'll probably tell you that Fedora 32 is EOL. 👍 66
Okay, so we have 17 votes in favour of zip
, 12 for weave
, 5 for spritz
, and somehow only 2 for interleave
. Oh, and 1 each for sprinkle
, intersperse_at_least_two_iterators_with_each_other
, and sum
. I'm beginning to suspect botting. 👍 7 😕 12
Hey read bean
- this pull request is out of sync with main
. Could you rebase on top of the twelve thousand commits that have occurred since you opened this? Thanks! 👍 63 🚀 2
whats stoping this from being merged? can we get an eta 👍 12 😕 2
It's mostly a debate on the name to use. I'm not sure why people aren't voting for interleave
. I've provided numerous arguments as to why it's the obvious option, and I've even linked a conversation with ChatGPT 4-o proving that it makes the most sense. Sigh. 👍 2 😕 70 😆 11
ℹ️ Pull request #53223 "Add interleave method to iterators" was marked as a duplicate of this one.
↕️ This comment was marked as off-topic.
🤖 No activity detected for 90 days. 👎 121 😕 89
Stalebot 🤖 marked this pull request as stale.
Conversation locked and limited to contributors.